fix: card overlay not toggling between upvote and bookmark #3831
+41
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhi-Bohora
requested review from
rebelchris,
omBratteng,
ilasw,
capJavert,
sshanzel,
nensidosari and
AmarTrebinjac
|
@Abhi-Bohora is attempting to deploy a commit to the Daily Dev Team on Vercel. A member of the Team first needs to authorize it. |
|
things i have noticed while solving this issue is in the original code if you click on upvote and than click on bookmarks afterwards than this if condition if (shouldShowOverlay && onShare) {
return (
<CardCoverShare
post={post}
onCopy={onInteract}
onShare={() => {
onInteract();
onShare(post);
}}
/>
);
}gets triggered both the time. while going otherway if you first click on bookmark and than upvote than each individual if condition gets triggered properly and works fine. |
sshanzel
reviewed
Nov 19, 2024
|
Hello @sshanzel thanks for feedback, i have implemented this way tracking the current interaction and showing the overlay accordingly. please have a look and if you have something in mind please suggest me i will try to implement that way. currently this is what i came up with. |
sshanzel
approved these changes
Nov 21, 2024
sshanzel
reviewed
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
fixes: #1510
Describe what this PR does
The problem here was if i click on upvote and click the bookmark afterwards
(upvote should be still clicked)the overlay of the upvote still remains in the card and the overlay the bookmark doesn't appear. but the opposite works fine if i click on bookmark first and than on upvote(bookmark should be still clicked)then it first shows the overlay of bookmark and than overlay of the upvote when each of the specific button is pressed.so I have come up with this solution to fix that issue, I don't know if this is the best approach to solve this issue. and please i need feedback if there can be easier solution or if i am missing something 🙏
Before:
before.mp4
After:
after.mp4
Events
Did you introduce any new tracking events?
If yes please remove the comment HTML comment tags and fill the table below
Don't forget to update the Analytics Taxonomy sheet
Log the new/changed events below:
-->
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR