-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Proleptic Julian calendar #54
Comments
As of now Pythagoras (Q10261)'s DOB (P569) on Wikidata has the below value: {
"type": "time",
"value": {
"time": "-0582-00-00T00:00:00Z",
"timezone": 0,
"before": 0,
"after": 0,
"precision": 7,
"calendarmodel": "http://www.wikidata.org/entity/Q1985786"
}
} And the calendar model it refers to (Q1985786) apparently not just BCE, but Proleptic Julian calendar. It means we need to handle leap years in a different way to how Python's What I mean is not I won't implement this calendar model, but just it would take a long time. However, if somebody sends a patch to implement this I'm going to happily review it! |
Hi, first of all I would like to thank @dahlia for providing this useful package. I had a problem similar than @mmejai with entity: https://www.wikidata.org/wiki/Q675908 A workaround may be to automatically convert julian dates to gregorian dates with package https://pypi.org/project/juliandate . I may propose to contribute to this work but I would prefer having maintainer's stance on the way to manage these heterogenous formats before trying to implement something... |
When fetching date of birth (P569) of Pythagoras (Item: Q10261) I got a DatavalueError... unsupported calendarmodel for time datavalue. Can you add/adjust the calender model to support for date of birth BCE. Many thanks.
The text was updated successfully, but these errors were encountered: