Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive template auth #613

Merged
merged 10 commits into from
Nov 7, 2024

Conversation

Abiji-2020
Copy link
Contributor

@Abiji-2020 Abiji-2020 commented Oct 6, 2024

closes #604

📑 Description

To the issue when there are no flags given in the command line a interactive command line will ask for the details of the repo, username Name and key and the password name and the key and creates the template auth.

✅ Checks

  • I have tested my code (provide screenshots or screen recordings of a working solution)
  • I have performed a self-review of my code

ℹ Additional context

  • Interactive command line
    image

  • When we didnt give the value for username
    image

  • final demo
    image

@Abiji-2020 Abiji-2020 requested a review from a team as a code owner October 6, 2024 07:19
@Abiji-2020
Copy link
Contributor Author

@quest-bot loot #604

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 6, 2024
Copy link

quest-bot bot commented Oct 6, 2024

Quest PR submitted! image Quest PR submitted!

@Abiji-2020, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

@Abiji-2020
Copy link
Contributor Author

Abiji-2020 commented Oct 7, 2024

@petar-cvit, @KaradzaJuraj any updates on this PR ?

cyctl/internal/create/template_auth_rules.go Outdated Show resolved Hide resolved
cyctl/internal/create/template_auth_rules.go Outdated Show resolved Hide resolved
cyctl/internal/create/template_auth_rules.go Outdated Show resolved Hide resolved
cyctl/internal/create/template_auth_rules.go Outdated Show resolved Hide resolved
cyctl/internal/create/template_auth_rules.go Outdated Show resolved Hide resolved
Comment on lines 31 to 34
usernameName string
passwordName string
usernameKey string
passwordKey string
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove these four from here. username and password are here because those are used to bind flag values

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this I have a doubt here that we are taking the individuals and should we need to add the values the same as username secret name: username secret key , and password secret name: password secret key

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abiji-2020 I would just move these variables to createTemplateAuthRule function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petar-cvit could you check it

Copy link
Contributor Author

@Abiji-2020 Abiji-2020 Oct 31, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petar-cvit Modified it.

@Abiji-2020
Copy link
Contributor Author

@petar-cvit all the requested changes are resolved.

Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Abiji-2020 🧡

@petar-cvit petar-cvit merged commit cfb9346 into cyclops-ui:main Nov 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cyctl interactive template auth rule creation
2 participants