-
Notifications
You must be signed in to change notification settings - Fork 772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive template auth #613
Interactive template auth #613
Conversation
…re no flags given while giving the command Signed-off-by: Abinand P <[email protected]>
@quest-bot loot #604 |
Quest PR submitted!@Abiji-2020, you are attempting to solve the issue and loot this Quest. Will you be successful? Questions? Check out the docs. |
@petar-cvit, @KaradzaJuraj any updates on this PR ? |
usernameName string | ||
passwordName string | ||
usernameKey string | ||
passwordKey string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove these four from here. username
and password
are here because those are used to bind flag values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this I have a doubt here that we are taking the individuals and should we need to add the values the same as username secret name: username secret key , and password secret name: password secret key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abiji-2020 I would just move these variables to createTemplateAuthRule
function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petar-cvit could you check it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petar-cvit Modified it.
Co-authored-by: Petar Cvitanović <[email protected]>
Co-authored-by: Petar Cvitanović <[email protected]>
Co-authored-by: Petar Cvitanović <[email protected]>
Co-authored-by: Petar Cvitanović <[email protected]>
…ocalization Signed-off-by: Abinand P <[email protected]>
@petar-cvit all the requested changes are resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Abiji-2020 🧡
closes #604
📑 Description
To the issue when there are no flags given in the command line a interactive command line will ask for the details of the repo, username Name and key and the password name and the key and creates the template auth.
✅ Checks
ℹ Additional context
Interactive command line
When we didnt give the value for username
final demo