Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds printer columns for cyclops modules #492

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ashish111333
Copy link
Contributor

closes #428

πŸ“‘ Description

This PR adds printer columns for cyclops modules.

βœ… Checks

  • I have updated the documentation as required
  • I have performed a self-review of my code

Additional context

@ashish111333 ashish111333 requested a review from a team as a code owner August 2, 2024 23:29
@petar-cvit
Copy link
Collaborator

To generate CRD yamls, you need to run make manifests and make generate from the cyclops-ctrl which will update yamls in cyclops-ctrl/config/crd/bases. I tried it on my local machine, but my version of go and version of controller-gen are not compatible.

@ashish111333 can you run those two commands and commit the changes generated?

@ashish111333
Copy link
Contributor Author

I see their is a bug in controller-gen .11 that causes panic, we should update it.

@petar-cvit
Copy link
Collaborator

Yup, found this comment on a controller gen issue

@ashish111333
Copy link
Contributor Author

@petar-cvit done.

@petar-cvit
Copy link
Collaborator

@ashish111333 tried it locally, and controller-gen now works. However, it seems like it didn't generate additionalPrinterColumns . Can you look into that?

@ashish111333
Copy link
Contributor Author

@ashish111333 tried it locally, and controller-gen now works. However, it seems like it didn't generate additionalPrinterColumns . Can you look into that?

Let me try, will update you.

@petar-cvit
Copy link
Collaborator

@ashish111333 did you manage to generate printer columns?

@ashish111333
Copy link
Contributor Author

@petar-cvit
Got a little busy , I will try to finish it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add additional printer columns to Cyclops Modules
2 participants