Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#148array validation expanded #630

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Ujj1225
Copy link

@Ujj1225 Ujj1225 commented Oct 13, 2024

closes #148

📑 Description

ArrayField Component intially supported only Strings and Objects. I updated the ArrayField component by adding conditions to handle different data types within arrays:

  • Numbers: Used InputNumber wrapped in a Form.
  • Booleans: Used Checkbox with valuePropName="checked" inside Form.Item.

These changes allow the component to dynamically render inputs based on the data type defined in field.items.type.

✅ Checks

  • I have performed a self-review of my code

@Ujj1225 Ujj1225 requested a review from a team as a code owner October 13, 2024 11:32
@Ujj1225
Copy link
Author

Ujj1225 commented Oct 13, 2024

@quest-bot loot #148

@quest-bot quest-bot bot added the ⚔️ Quest Tracks quest-bot quests label Oct 13, 2024
Copy link

quest-bot bot commented Oct 13, 2024

Quest PR submitted! image Quest PR submitted!

@Ujj1225, you are attempting to solve the issue and loot this Quest. Will you be successful?


Questions? Check out the docs.

@Ujj1225
Copy link
Author

Ujj1225 commented Nov 7, 2024

@petar-cvit please review

Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number and boolean arrays do not behave like array, but as a single input field.

Screenshot 2024-11-07 at 22 38 37

@Ujj1225
Copy link
Author

Ujj1225 commented Nov 8, 2024

@petar-cvit check now

Copy link
Collaborator

@petar-cvit petar-cvit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ujj1225, can you provide a screenshot of the solution?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚔️ Quest Tracks quest-bot quests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add better support for array validations
2 participants