Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration best practices #7

Open
lucasfeliciano opened this issue Apr 16, 2019 · 1 comment
Open

Configuration best practices #7

lucasfeliciano opened this issue Apr 16, 2019 · 1 comment

Comments

@lucasfeliciano
Copy link

lucasfeliciano commented Apr 16, 2019

I'm facing the same issue as described here: 3rd-Eden#339

I'm still using 3rd-Eden package, but worth the shot asking here if you know how this issue could be solved.

My current config is and I don't run in cluster mode:

const memcached = new Memcached(MEMCACHED_ADDRESS, {
  maxExpiration: MAX_EXPIRATION_TIME,
  maxValue: 2097152, // Max length of cache value in bytes
  timeout: 3000, // after x ms the server should send a timeout if we can't connect
  poolSize: 50, // maximal parallel connections
  retries: 2, // Connection pool retries to pull connection from pool
  minTimeout: 500, // Connection pool retry min delay before retrying
  maxTimeout: 1000, // Connection pool retry max delay before retrying
  retry: 1000, // When a server has an error, wait this amount of time before retrying
})

I'm also wondering if this was a 1-to-1 rewrite or did you guys fix any bugs and are going to maintain this lib?

It is my interest to update to a lib that at least is minimally maintained

@ramakrishna-battala-ck
Copy link

Hey @lucasfeliciano sorry for the delay in responding back. We had a couple of issues in the original repo. However, we figured that this repo was not actively making any new releases, and hence forked a copy. The intention of this repo was to minimally maintain it.

It was mainly a 1-to-1 rewrite of the repo, with the following changes,
i) adding Typescript support
ii) Update any dependencies
iii) Promisifying the API's
iv) Pulled the fix (294)
v) Exposed addListener for custom listeners

Most of this was remerged back to v3.0.x (332) in the original repo (except for fifth point above).

If you see any additional value using this repo, please feel free to use it and let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants