Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] [future-work] Use consistent well-documented exception types #155

Open
bchess opened this issue Jun 27, 2024 · 0 comments
Open

[3.0] [future-work] Use consistent well-documented exception types #155

bchess opened this issue Jun 27, 2024 · 0 comments
Milestone

Comments

@bchess
Copy link
Contributor

bchess commented Jun 27, 2024

From @Eta0 in #127 (review)

  • Use more consistent and documented exception types
    • E.g. some sort of InvalidTensorizerFile exception when deserializing, which could have subtypes like UnsupportedTensorizerVersion
    • This would just make it a bit easier for code using tensorizer to differentiate between bad files or issues with their system, library dependency versions, deserialization flags they requested, or various other things
    • Having a smaller, documented set of errors in the outer layer of the API makes it so people don't have to use except Exception as often, which is usually nice
@bchess bchess added this to the 3.0 milestone Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant