feat(container): add support for verify-clients #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChandonPierre
force-pushed
the
cpierre/verify-clients
branch
from
5a1d967
to
69de0ef
Compare
ChandonPierre
commented
Nov 14, 2024
| # Start tailscaled and call tailscale up if we need to verify clients | ||
| if [[ $DERP_VERIFY_CLIENTS == "true" ]]; then | ||
| # Start and background tailscaled | ||
| setsid $TSD_CMD > /dev/stdout 2> /dev/stderr & |
There was a problem hiding this comment.
The canonically correct way to do this is probably to run tailscaled in a separate container and share the socket with the derper container 🤔
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for
derper --verify-clientsby addingtailscaledandtailscale.The daemon is backgrounded before calling the main
derperprocess.Health Check periodically validates if the client is online from the Tailscale control plane, which should catch the daemon exiting.
Closes #70