Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub autogenerated tarballs not considered stable #2458

Open
palmskog opened this issue Jan 30, 2023 · 7 comments
Open

GitHub autogenerated tarballs not considered stable #2458

palmskog opened this issue Jan 30, 2023 · 7 comments

Comments

@palmskog
Copy link
Contributor

Due to GitHub changing compression approach on Jan 30, 2023, every auto-generated GitHub hosted tarball now has a different checksum. The archive content is the same.

The following is GitHub's message to anyone affected by this, like us:

GitHub doesn't guarantee the stability of checksums for automatically generated archives. If you need to rely on a consistent checksum, you may upload archives directly to GitHub Releases.

So it seems we have to both (1) ensure checksums are refreshed for all GitHub tarballs in the archive and (2) ensure that only stable archives are used in packages going forward...

@palmskog
Copy link
Contributor Author

If anyone is looking for a workaround, the following may be used:

opam install <package> --no-checksums

@erikmd maybe we can use this by default in the Coq Docker? Unless checksums get rolled back (unlikely) this will take the whole OCaml and Coq ecosystem some time to work around.

@palmskog
Copy link
Contributor Author

GitHub may be in the process of reverting the change:

We're sorry for the breakage, we're reverting the change, and we'll communicate better about such changes in the future (including timelines).

@palmskog palmskog changed the title GitHub tarball checksum changes GitHub autogenerated tarballs not considered stable Jan 31, 2023
@palmskog
Copy link
Contributor Author

From what I can tell, GitHub has now rolled back the tarball checksum changes. But the central problem remains in the long term: autogenerated GitHub tarballs are probably not trustworthy for preservation of code in the OCaml and Coq ecosystem.

@LasseBlaauwbroek
Copy link
Member

I just saw that an official request for feedback on this problem was opened: community/community#46034
Could be a good idea to add Coq's or OCaml's usecase there.

@ybertot
Copy link
Contributor

ybertot commented Feb 24, 2023

What I understand from reeding this link is that the problem needs to be handled by opam. A solution that comes to mind is to hash, not on the compressed archive, but on the uncompressed one (or any result given by a chosen filter).

@gares
Copy link
Member

gares commented Feb 24, 2023

Opam could hash the uncompressed, and be future proof. But we have a lot of packages which declare the hash of the compressed archive. For these we would need some automation to update the hash, once opam understands the new hashing schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants