Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math-comp-field-extra #1300

Open
CohenCyril opened this issue Jun 16, 2020 · 4 comments
Open

math-comp-field-extra #1300

CohenCyril opened this issue Jun 16, 2020 · 4 comments

Comments

@CohenCyril
Copy link
Contributor

CohenCyril commented Jun 16, 2020

@clarus I just realized that this package was added and committed in 51d4388 with maintainer "Mathematical Components [email protected]". To my knowledge this has not been discussed there, and this package does not correspond to any of our packages, so I am very surprised. Can you tell me the story of this package?

@clarus
Copy link
Contributor

clarus commented Jun 16, 2020

Indeed, I did not remember it. I found the related issue: #802 I should have mentioned mathcomp developers though.

@palmskog
Copy link
Contributor

The bottom line is that this package was added by @clarus and myself to preserve an old version of odd-order. It was a mistake to set mathcomp-dev as a maintainer (this was due to us just copying another opam file).

@CohenCyril
Copy link
Contributor Author

CohenCyril commented Jun 16, 2020

mmh, I see, I would have preferred to copy the missing files from field/ to odd-order/ (and amending odd-order/Makefile accordingly) in the build phase rather than creating an ad-hoc package. Do you think we can alter this safely, or that we should absolutely not touch it, or that we should not care since this is old stuff? (It does pollute the opam-coq-archive repo and opam list forever though)

@palmskog
Copy link
Contributor

palmskog commented Jun 16, 2020

Creating a new package was viewed as the most straightforward solution at the time (given that there are already quite a few historical packages).

@CohenCyril if you want to alter the package definition of odd-order.1.6.1, to make the field-extra package obsolete, this is fine by me. But I still think we should keep odd-order.1.6.1 functional in some way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants