Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*Properly* fix both GitHub Actions CI and Appveyor CI #2

Open
cooljeanius opened this issue Sep 21, 2023 · 8 comments
Open

*Properly* fix both GitHub Actions CI and Appveyor CI #2

cooljeanius opened this issue Sep 21, 2023 · 8 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@cooljeanius
Copy link
Owner

Looks like there's an issue with script/uberjar:

$ script/uberjar
+rm -f resources/brepl_client.js
+MAJOR=1
+MINOR=11
++git --no-replace-objects describe --match v1.11
fatal: No names found, cannot describe anything.
+REVISION=
The command "script/uberjar" failed and exited with 128 during .

Your build has been stopped.
@cooljeanius cooljeanius added bug Something isn't working help wanted Extra attention is needed labels Sep 21, 2023
cooljeanius added a commit that referenced this issue Sep 21, 2023
@cooljeanius
Copy link
Owner Author

it's weird because the script runs fine locally, so I dunno what's different about the CI environment that causes it to fail there...

@cooljeanius
Copy link
Owner Author

ok so now the uberjar script gets a bit farther, but then it dies when the clojure process it spawns crashes:

+clojure -X:uberjar :jar target/cljs.jar :compile-ns :all
Exception in thread "main" java.lang.ExceptionInInitializerError
	at clojure.main.<clinit>(main.java:20)
Caused by: java.lang.IllegalArgumentException: Must hint overloaded method: toArray, compiling:(clojure/gvec.clj:131:1)
	at clojure.lang.Compiler.analyzeSeq(Compiler.java:6875)
	at clojure.lang.Compiler.analyze(Compiler.java:6669)
	at clojure.lang.Compiler.analyze(Compiler.java:6625)
	at clojure.lang.Compiler$BodyExpr$Parser.parse(Compiler.java:6003)
	at clojure.lang.Compiler$LetExpr$Parser.parse(Compiler.java:6319)
	at clojure.lang.Compiler.analyzeSeq(Compiler.java:6868)
	at clojure.lang.Compiler.analyze(Compiler.java:6669)
	at clojure.lang.Compiler.analyze(Compiler.java:6625)
	at clojure.lang.Compiler$BodyExpr$Parser.parse(Compiler.java:6005)
	at clojure.lang.Compiler$FnMethod.parse(Compiler.java:5380)
	at clojure.lang.Compiler$FnExpr.parse(Compiler.java:3972)
	at clojure.lang.Compiler.analyzeSeq(Compiler.java:6866)
	at clojure.lang.Compiler.analyze(Compiler.java:6669)
	at clojure.lang.Compiler.eval(Compiler.java:6924)
	at clojure.lang.Compiler.load(Compiler.java:7379)
	at clojure.lang.RT.loadResourceScript(RT.java:372)
	at clojure.lang.RT.loadResourceScript(RT.java:363)
	at clojure.lang.RT.load(RT.java:453)
	at clojure.lang.RT.load(RT.java:419)
	at clojure.core$load$fn__1621.invoke(core.clj:5893)
	at clojure.core$load.invokeStatic(core.clj:5892)
	at clojure.core$load.doInvoke(core.clj:5876)
	at clojure.lang.RestFn.invoke(RestFn.java:408)
	at clojure.core$eval3106.invokeStatic(core.clj:6523)
	at clojure.core$eval3106.invoke(core.clj:6523)
	at clojure.lang.Compiler.eval(Compiler.java:6927)
	at clojure.lang.Compiler.load(Compiler.java:7379)
	at clojure.lang.RT.loadResourceScript(RT.java:372)
	at clojure.lang.RT.loadResourceScript(RT.java:363)
	at clojure.lang.RT.load(RT.java:453)
	at clojure.lang.RT.load(RT.java:419)
	at clojure.lang.RT.doInit(RT.java:461)
	at clojure.lang.RT.<clinit>(RT.java:331)
	... 1 more
Caused by: java.lang.IllegalArgumentException: Must hint overloaded method: toArray
	at clojure.lang.Compiler$NewInstanceMethod.parse(Compiler.java:8206)
	at clojure.lang.Compiler$NewInstanceExpr.build(Compiler.java:7798)
	at clojure.lang.Compiler$NewInstanceExpr$DeftypeParser.parse(Compiler.java:7678)
	at clojure.lang.Compiler.analyzeSeq(Compiler.java:6868)
	... 33 more
The command "script/uberjar" failed and exited with 1 during .

Your build has been stopped.

@cooljeanius
Copy link
Owner Author

OK so I'm just hacking around the errors on GitHub Actions by ignoring them for now; I should still probably fix them properly, though. Also the Appveyor workflow still fails, too.

@cooljeanius cooljeanius changed the title Fix CI Fix Appveyor CI, and *properly* fix GitHub Actions CI Oct 30, 2023
cooljeanius added a commit that referenced this issue Oct 30, 2023
…ions/checkout-4

Bump actions/checkout from 3 to 4
(appveyor failures are tracked in #2 already)
@cooljeanius
Copy link
Owner Author

ok I managed to hack around the Appveyor failure, too, but that deserves a proper fix as well...

@cooljeanius cooljeanius changed the title Fix Appveyor CI, and *properly* fix GitHub Actions CI *Properly* fix both GitHub Actions CI and Appveyor CI Nov 10, 2023
@cooljeanius
Copy link
Owner Author

Now seen in PR #47: failure to download ChakraCore from https://aka.ms/chakracore/cc_windows_all_1_8_1 properly... maybe there's an archived copy somewhere? I couldn't seem to find one on the Wayback Machine when I looked...

@cooljeanius
Copy link
Owner Author

Now seen in PR #47: failure to download ChakraCore from aka.ms/chakracore/cc_windows_all_1_8_1 properly... maybe there's an archived copy somewhere? I couldn't seem to find one on the Wayback Machine when I looked...

Seen in PR #48, too...

@cooljeanius
Copy link
Owner Author

Ah, apparently this is due to chakra-core/ChakraCore#6991 ...

@cooljeanius
Copy link
Owner Author

Ah, apparently this is due to chakra-core/ChakraCore#6991 ...

OK, I've got a workaround for this for now; leaving this open for replacing hacks with proper fixes...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant