Merge pull request #14 from tylerfanelli/vcpu_max

context: Add max vCPU check
containers · Jul 18, 2024 · 29f5ada · 29f5ada
2 parents 2d3599d + 377c032
commit 29f5ada
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "krunkit"
-version = "0.1.1"
+version = "0.1.2"
 authors = ["Tyler Fanelli <[email protected]>"]
 edition = "2021"
 description = "CLI tool to start VMs with libkrun"

diff --git a/src/context.rs b/src/context.rs
@@ -46,8 +46,12 @@ impl TryFrom<Args> for KrunContext {
         let id = u32::try_from(id).unwrap();
 
         // Set the krun VM's number of vCPUs and amount of memory allocated.
+        //
+        // libkrun has a max of 8 vCPUs allowed.
         if args.cpus == 0 {
             return Err(anyhow!("zero vcpus inputted (invalid)"));
+        } else if args.cpus > 8 {
+            return Err(anyhow!("too many vCPUs configured (max 8)"));
         }
 
         if args.memory == 0 {