Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding safehttpx #28301

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Adding safehttpx #28301

merged 4 commits into from
Nov 22, 2024

Conversation

HeavyTony2
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/safehttpx/meta.yaml) and found it was in an excellent condition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is supposed to be compatible with 3.9 too, but
https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=1087699&view=logs&j=4cabe686-70ae-553a-7fd0-310379f2cbac&t=6a4fc7c9-c31a-5115-eff9-6479d72b69ff&l=910

import: 'safehttpx'
Traceback (most recent call last):
  File "/home/conda/staged-recipes/build_artifacts/safehttpx_1732226167030/test_tmp/run_test.py", line 2, in <module>
    import safehttpx
  File "/home/conda/staged-recipes/build_artifacts/safehttpx_1732226167030/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.9/site-packages/safehttpx/__init__.py", line 79, in <module>
    class AsyncSecureTransport(httpx.AsyncHTTPTransport):
  File "/home/conda/staged-recipes/build_artifacts/safehttpx_1732226167030/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/lib/python3.9/site-packages/safehttpx/__init__.py", line 88, in AsyncSecureTransport
    _timeout: float | None = None,
TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'
WARNING: Tests failed for safehttpx-0.1.1-pyhff2d567_0.conda - moving package to /home/conda/staged-recipes/build_artifacts/broken

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already signaled the issue upstream gradio-app/safehttpx#5

@HeavyTony2
Copy link
Contributor Author

@conda-forge/help-python, ready for review

@synapticarbors synapticarbors merged commit 90a9f8e into conda-forge:main Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants