Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for pull requests made from non-forks #437

Open
chrisburr opened this issue Mar 12, 2021 · 5 comments
Open

Check for pull requests made from non-forks #437

chrisburr opened this issue Mar 12, 2021 · 5 comments

Comments

@chrisburr
Copy link
Member

It would be nice to detect and then comment on PRs with an explanation of why PRs need to be made from forks.

@beckermr
Copy link
Member

That's a great idea. We should do this in the webservices bot though.

@beckermr beckermr transferred this issue from conda-forge/conda-forge-status-monitor Mar 12, 2021
@beckermr
Copy link
Member

This bot already handles PR events for linting and commands. I think it should be an easy addition to check what repo the head is in.

@beckermr
Copy link
Member

I think if you put the check here: https://github.com/conda-forge/conda-forge-webservices/blob/master/conda_forge_webservices/commands.py#L73 it will catch things easily.

@jakirkham
Copy link
Member

Just another thought, if we make this a separate status and make it required, this would ensure that people can't push non-checked commits to branches (thus protecting against a lot of the bad outcomes here)

@beckermr
Copy link
Member

cc @conda-forge/core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants