Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reenable DEFAULT_LINUX_VERSION for cos7, alma8, alma9, etc. #6629

Closed
beckermr opened this issue Oct 30, 2024 · 2 comments · Fixed by #6626
Closed

reenable DEFAULT_LINUX_VERSION for cos7, alma8, alma9, etc. #6629

beckermr opened this issue Oct 30, 2024 · 2 comments · Fixed by #6626

Comments

@beckermr
Copy link
Member

This option was removed when we dropped cos6.

Per the discussion on the core call, we are going to reenable this option since the CUDA zip in the pinnings makes it hard to do this in the cbc.yaml directly.

cc @h-vetinari @isuruf

@beckermr beckermr changed the title reenable DEFAULT_LINUX_VERSION for cos7, alma8, alma9, etc. reenable DEFAULT_LINUX_VERSION for cos7, alma8, alma9, etc. Oct 30, 2024
@jakirkham
Copy link
Member

Have implemented this for cos7 and alma8 in PR: #6548

It would be simple to extend to alma9 when we are ready

@h-vetinari
Copy link
Member

I also updated my PR to do this (including the alma9 images and removing cdt_name from the zip). However, I wanted to note a pertinent comment in the discussion in #6548 that we could simply always use the newest available image by default. This should obsolete the necessity for DEFAULT_LINUX_VERSION completely, because the only point where we really need that is if we need a newer image for some reason.

This comment is mostly for cross-referencing purposes, I think the discussion fits better in #6283, which is where I put my thoughts on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants