Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate libprotobuf 4.23 & grpc 1.55 (additionally to existing pins) #4482

Merged
merged 1 commit into from
May 24, 2023
Merged

migrate libprotobuf 4.23 & grpc 1.55 (additionally to existing pins) #4482

merged 1 commit into from
May 24, 2023

Conversation

h-vetinari
Copy link
Member

Main discussion for this happened in #4075.

The situation:

  • protobuf has a new version scheme where, the middle number is the feature level, and the "major" version corresponds to the language bindings -- e.g. v21.12 == v3.21.21 (C++) == v4.21.12 (python)
  • the short-lived 22-series bumped the major version for C++ and also introduced a dependence on abseil, not just internally, but in the API. This will become painful later, but not now at least
  • not only does it depend on abseil, but also abseil's test targets, which didn't compile yet with shared builds on windows and thus took a while
  • libgrpc 1.55 is apparently only compatible with protobuf 4.23, hence the zip-keys here

Due to the potential fall-out from the major version bump, I'm suggesting to do a dual protobuf pin (see also #4068). This is fortuitous timing, because we've just completed a long-standing grpc-refactor as well (adding shared libs on windows, removing some run-exports for private libs), which will ease digesting that.

Closes #4068
Closes #4075
Closes #4436
Closes #4454

@h-vetinari h-vetinari requested a review from a team as a code owner May 24, 2023 02:04
@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari h-vetinari mentioned this pull request May 24, 2023
Open
3 tasks
@kkraus14
Copy link
Contributor

This looks reasonable to me given the whole situation with things.

@kkraus14 kkraus14 merged commit 81d7e51 into conda-forge:main May 24, 2023
@h-vetinari h-vetinari deleted the proto_4 branch May 24, 2023 03:19
@h-vetinari h-vetinari mentioned this pull request May 24, 2023
Closed
2 tasks
@ngam
Copy link
Contributor

ngam commented May 25, 2023 •
edited
Loading

@h-vetinari are you tracking issues related to this? We need to get core deps to run (e.g., bazel is half-failing, that is, the newer zipped pins are failing). Is that anticipated or should we follow up on a case-by-case basis?

-   - package libgrpc-1.55.0-h59456c1_0 requires libprotobuf >=4.23.1,<4.24.0a0, but none of the providers can be installed

@h-vetinari
Copy link
Member Author

@h-vetinari are you tracking issues related to this?

I think it would be best to reopen #4075, but I don't have the rights to do that. Bazel needs conda-forge/grpc_java_plugin-feedstock#57

@h-vetinari h-vetinari mentioned this pull request Aug 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Next round of abseil / grpc / protobuf upgrades Dual libprotobuf pin
3 participants
@h-vetinari @kkraus14 @ngam