Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make OnJoin private #216

Open
endel opened this issue Jul 4, 2023 · 0 comments
Open

Make OnJoin private #216

endel opened this issue Jul 4, 2023 · 0 comments

Comments

@endel
Copy link
Member

endel commented Jul 4, 2023

The room's OnJoin event is internal and should not be exposed publicly:

/// <summary>
/// Occurs when the <see cref="ColyseusClient" /> successfully connects to the <see cref="ColyseusRoom{T}" />.
/// </summary>
public event ColyseusOpenEventHandler OnJoin;

This causes confusion to some users starting out as OnJoin is not necessary to detect joins since version 0.14. This event is leftover from previous iterations and must be refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant