Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI should scale to fill more of the screen #38

Open
bdjewkes opened this issue Aug 10, 2019 · 0 comments
Open

UI should scale to fill more of the screen #38

bdjewkes opened this issue Aug 10, 2019 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@bdjewkes
Copy link
Collaborator

Currently the UI doesn't use space very efficiently, and is having its size set by px widths and heights. I think it'll be easier to iterate on the client UI layout if we do something like cssgrid fractions (fr), and viewport units (vh, vw).

The wrinkle to this that I'm not sure offhand how to resolve is that the canvas rendered game view will need to maintain its aspect. Right now the aspect is set via the width and height of the canvas, and the scaling of tiles in the canvas is calculated based on those values. It could be that the aspect could be recalculated, or maybe there is a cleaner all-around solution

@bdjewkes bdjewkes added the help wanted Extra attention is needed label Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant