-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard Approach NestJS Fix #52
Conversation
Honestly, Linters are crazy, fixing them up. |
Really I would admire, if linting check is not done at least on server for now. |
Did you tried running |
Can you add this to your GitHub Actions ? |
@Abhishek-kumar09 I added few a command to let Workflow run, the |
I see, we are doing this to serialize the returned object.
Infact, we don't need library specific response here, I believe. |
Yes and thats why to maintain standard approach |
I meant removing |
We do need |
Not really, When we are using When we are returning the object using standard approach, we can omit the use of Here is the example of removal of |
Description
The following changes in the code enable the automatic NestJS serialization for JSON which was turned off, while using Library Specific
@Res
This PR also adds a workflow command
npm run lint:fix
to fix the lints.Related Issue
Fixes #51
Type of Change:
Code/Quality Assurance Only
Additional Info (OPTIONAL)
NestJS Standard Approach is mentioned over here
Checklist