This repository has been archived by the owner on Mar 7, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 78
Added Selectors for State Districts and Colleges #78
Open
Abhishek-kumar09
wants to merge
5
commits into
codeforcauseorg:development
Choose a base branch
from
Abhishek-kumar09:jason_filtering
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added Selectors for State Districts and Colleges #78
Abhishek-kumar09
wants to merge
5
commits into
codeforcauseorg:development
from
Abhishek-kumar09:jason_filtering
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abhishek-kumar09
force-pushed
the
jason_filtering
branch
from
September 20, 2020 17:18
1f27652
to
e53a1d3
Compare
@Abhishek-kumar09 We have made some breaking changes. you will need to rebase |
rebased |
@@ -93,7 +97,7 @@ export function ApplicationSteps({ applicationId, setCourseTitle }) { | |||
const isMountedRef = useIsMountedRef(); | |||
const baseUrl = | |||
'https://us-central1-codeforcauseorg.cloudfunctions.net/widgets/applications/request'; | |||
const [activeStep, setActiveStep] = React.useState(-1); | |||
const [activeStep, setActiveStep] = React.useState(1); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temporary, just for easy review
1st thing to change after/before merging PR
.fill(2000) | ||
.map((x, y) => x + y); | ||
.fill(2024) | ||
.map((x, y) => x - y); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most often, Courses will be booked by recent graduates, so reversed the array from
2000-2024
to 2024-2000
If we change state - District and College should change to blank If we change District - College should change to blank |
@KeenWarrior Done |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.