Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

Remove all the unused dependencies which are nowhere used #152

Open
idontknowjs opened this issue Nov 9, 2020 · 7 comments
Open

Remove all the unused dependencies which are nowhere used #152

idontknowjs opened this issue Nov 9, 2020 · 7 comments

Comments

@idontknowjs
Copy link
Contributor

There are many dependencies like "react-quill", "formik", "immutable", "react-draft-wysiwyg" and many more...

image

@Abhishek-kumar09
Copy link
Contributor

Thanks @CovalentBond for raising this detailed issue.

react-quill", "formik", "immutable", "react-draft-wysiwyg"

Ya, they are used no where.

For the image - These all are unused, but the similar ones are used within the code, Please assure that the code functionality is not compromised by removing them.

@idontknowjs
Copy link
Contributor Author

Those which are shown in the image have not been imported anywhere in the code. The image is a result of a library "depcheck" which shows the unused dependencies.

But it cannot be completely correct, as it showed "keycloak-js" as one of the unused dependencies as it's not imported. But "keycloack-js" is also not imported but actually used in one of the files.

The only way to this is checking manually each of the dependencies, whether it has been used anywhere in the project or not.
There might be even more which are not stated above

@Itsaadarsh
Copy link
Contributor

Hello, there @Abhishek-kumar09 @CovalentBond , is this issue still open? Because I'd love to work on this issue and resolve it.

@Abhishek-kumar09
Copy link
Contributor

@Itsaadarsh It's open.
But would you help in removing some console errors from the website first. This way you could learn more about codebase, and they are pretty easy too. You could remove few of them and make a PR.
https://github.com/codeforcauseorg/codeforcause.org/issues/92

@Abhishek-kumar09
Copy link
Contributor

Always feel free to tag me, as sometimes conversations are missed, and the fault is totally mine.

@Itsaadarsh
Copy link
Contributor

Yes sure thing @Abhishek-kumar09 , but first I'll send (#152) PR then I'll move towards the next. Because I'm done removing all the unused dependencies, I'll clean up a little and send the PR asap.

Itsaadarsh added a commit to Itsaadarsh/codeforcause.org that referenced this issue Jan 12, 2021
@Abhishek-kumar09
Copy link
Contributor

Great! thanks.

Itsaadarsh added a commit to Itsaadarsh/codeforcause.org that referenced this issue Jan 12, 2021
Itsaadarsh added a commit to Itsaadarsh/codeforcause.org that referenced this issue Jan 12, 2021
KeenWarrior pushed a commit that referenced this issue Jan 13, 2021
* Removing all the unused dependencies (#152)

* Adding stripe.js dependency back. (#152)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants