Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

[Feature request] dark mode #144

Open
haaarshsingh opened this issue Oct 27, 2020 · 13 comments
Open

[Feature request] dark mode #144

haaarshsingh opened this issue Oct 27, 2020 · 13 comments

Comments

@haaarshsingh
Copy link

Add a simple setting which makes the website go light, or dark, for the creatures of the night.

@Abhishek-kumar09
Copy link
Contributor

Fantastic one!
We thought of it earlier but could not apply due to several other things on pipeline.
Do you want to got for it?

@haaarshsingh
Copy link
Author

Yeah, glad to do it!

@Abhishek-kumar09
Copy link
Contributor

Great! Thanks for showing your interest :)

@haaarshsingh
Copy link
Author

I really apologise, with school and other side projects I haven't found the time to really work on this. Hope you can understand.

@Abhishek-kumar09
Copy link
Contributor

No worries, I understand. But I am re-opening this issue, so that other could come across and solve it. Thank You for opening it.

@sarvesha-jaiswal
Copy link

sarvesha-jaiswal commented Mar 21, 2021

is this issue is still open ? can i work on it?

@Abhishek-kumar09
Copy link
Contributor

Yes, here is the theme written: https://github.com/codeforcauseorg/codeforcause.org/blob/development/src/theme/index.js

You can change all the points were colors were written explicitly to the theme variables

@sarvesha-jaiswal
Copy link

yes sure!

@Anishpras
Copy link

Would like to work on this.

@sarvesha-jaiswal
Copy link

@Anishpras sorry, but i have started working on this issue, maybe if i need any help i will contact you

Thanks

@khushbooag4
Copy link

Is this issue still open

@Abhishek-kumar09
Copy link
Contributor

Oh hi @khushbooag4 Sorry I was missing the notifications for the vacations. I think this issue isn't fixed.
Better to able to create a toggle for dark mode.
The theme is already defined for dark:

https://github.com/codeforcauseorg/codeforcause.org/blob/0a5308d6772edb47508b4d012314c13e7fe941e5/src/theme/index.js#L69-L98

and applying a dark theme is done in mui in an easy way: https://adityanaik.dev/blog/2020/05/20/material-ui-how-to-easily-set-up-dark-theme-toggle-in-react/

@KeenWarrior @GangaChatrvedi will let you know more about the need of the dark mode in the current UI architecture

@KeenWarrior
Copy link
Contributor

@khushbooag4 We do not have the figma sheets ready for what we expect in dark mode. So completion of this issue will become ambiguous at this moment.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants