Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

[bug] Apply now button disabled #110

Open
pandafy opened this issue Sep 30, 2020 · 6 comments
Open

[bug] Apply now button disabled #110

pandafy opened this issue Sep 30, 2020 · 6 comments

Comments

@pandafy
Copy link
Contributor

pandafy commented Sep 30, 2020

From user experience perspective, I believe it will be better to change "Apply Now" to "Coming Soon" if that's the case.
Also the link points to a form to signup for Code For Cause newsletter. Is this desirable?

Screenshot from 2020-09-30 23-42-56

@madhhuurrii
Copy link

Hii I would like to work on this issue , but should i have change the link too to some other along with "coming soon" button

@pandafy
Copy link
Contributor Author

pandafy commented Oct 5, 2020

@Abhishek-kumar09 @KeenWarrior can you please tell if this is expected behaviour? If not can you please tell what path should be taken for this?

@Abhishek-kumar09
Copy link
Contributor

From user experience perspective, I believe it will be better to change "Apply Now" to "Coming Soon" if that's the case.

Its a good idea...thanks.

Also the link points to a form to signup for Code For Cause newsletter. Is this desirable?

I guess it is about getting personalized event updates and course updates, etc. It is desired.

@Abhishek-kumar09
Copy link
Contributor

Hii I would like to work on this issue , but should i have change the link too to some other along with "coming soon" button

No the button would be disabled and will not follow up to any link.

@Creatoon
Copy link

@Abhishek-kumar09 I think noone is working on this issue, so do i have to add "coming soon" Text on the button instead of apply now if the aria-disabled is true, and if the aria-disabled will be false then the button text should return to its initial text which is "Apply now".

Am I right?

@Abhishek-kumar09
Copy link
Contributor

Abhishek-kumar09 commented Feb 19, 2021

@Creatoon No see aria-label has to nothing to do with the button text here. Aria-label is just a kind of label that is only helpful in when someone uses screen narrator.

What you have to do is just change "Apply Now"to "Coming soon".

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants