test: refactor old tests and cleanup test helpers

.github/workflows/ci.yml

@@ -120,9 +120,7 @@ jobs:
       - name: Install dependencies
         run: npm ci
       - name: E2E test affected projects
-        run: npx nx affected -t nxv-e2e --exclude cli-e2e --parallel=1
-      - name: E2E test cli-e2e project (due to bugs in the setup it has to run last :( )
-        run: npx nx run cli-e2e:e2e-old
+        run: npx nx affected -t nxv-e2e --parallel=1
 
   build:
     runs-on: ubuntu-latest

code-pushup.config.ts

@@ -37,7 +37,7 @@ const config: CoreConfig = {
 
   plugins: [
     fileSizePlugin({
-      directory: './dist/examples/react-todos-app',
+      directory: './dist/packages',
       pattern: /\.js$/,
       budget: 174_080, // 170 kB
     }),

e2e/cli-e2e/mocks/fixtures/dummy-setup/code-pushup.config.js

@@ -0,0 +1,6 @@
+import dummyPlugin, { dummyCategory } from './dummy.plugin';
+
+export default {
+  plugins: [dummyPlugin()],
+  categories: [dummyCategory],
+};

e2e/cli-e2e/mocks/fixtures/dummy-setup/code-pushup.config.mjs

@@ -0,0 +1,6 @@
+import dummyPlugin, { dummyCategory } from './dummy.plugin';
+
+export default {
+  plugins: [dummyPlugin()],
+  categories: [dummyCategory],
+};

e2e/cli-e2e/mocks/fixtures/dummy-setup/code-pushup.config.ts

@@ -0,0 +1,6 @@
+import dummyPlugin, { dummyCategory } from './dummy.plugin';
+
+export default {
+  plugins: [dummyPlugin()],
+  categories: [dummyCategory],
+};

e2e/cli-e2e/mocks/fixtures/dummy-setup/dummy.plugin.ts

@@ -0,0 +1,50 @@
+import { readFile } from 'node:fs/promises';
+import { join } from 'node:path';
+import type { PluginConfig } from '@code-pushup/models';
+
+export const dummyPluginSlug = 'dummy-plugin';
+
+const dummyAuditSlug = 'dummy-audit';
+export const dummyAudit = {
+  slug: dummyAuditSlug,
+  title: 'Dummy Audit',
+  description: 'A dummy audit to test the cli.',
+};
+
+export const dummyCategory = {
+  slug: 'dummy-category',
+  title: 'Dummy Category',
+  refs: [
+    {
+      type: 'audit',
+      plugin: dummyPluginSlug,
+      slug: dummyAuditSlug,
+      weight: 1,
+    },
+  ],
+};
+
+export function create(): PluginConfig {
+  return {
+    slug: dummyPluginSlug,
+    title: 'Dummy Plugin',
+    icon: 'folder-javascript',
+    description: 'A dummy plugin to test the cli.',
+    runner: async () => {
+      const itemCount = JSON.parse(
+        await readFile(join('src', 'items.json'), 'utf-8'),
+      ).length;
+      return [
+        {
+          ...dummyAudit,
+          slug: dummyAuditSlug,
+          score: itemCount < 10 ? itemCount / 10 : 1,
+          value: itemCount,
+        },
+      ];
+    },
+    audits: [dummyAudit],
+  };
+}
+
+export default create;

e2e/cli-e2e/mocks/fixtures/dummy-setup/src/items.json

@@ -0,0 +1 @@
+[1, 2, 3]

e2e/cli-e2e/mocks/fixtures/existing-reports/code-pushup.config.ts

@@ -0,0 +1,6 @@
+import dummyPlugin, { dummyCategory } from './dummy.plugin';
+
+export default {
+  plugins: [dummyPlugin()],
+  categories: [dummyCategory],
+};

e2e/cli-e2e/mocks/fixtures/existing-reports/dummy.plugin.ts

@@ -0,0 +1,50 @@
+import { readFile } from 'node:fs/promises';
+import { join } from 'node:path';
+import type { PluginConfig } from '@code-pushup/models';
+
+export const dummyPluginSlug = 'dummy-plugin';
+
+const dummyAuditSlug = 'dummy-audit';
+export const dummyAudit = {
+  slug: dummyAuditSlug,
+  title: 'Dummy Audit',
+  description: 'A dummy audit to test the cli.',
+};
+
+export const dummyCategory = {
+  slug: 'dummy-category',
+  title: 'Dummy Category',
+  refs: [
+    {
+      type: 'audit',
+      plugin: dummyPluginSlug,
+      slug: dummyAuditSlug,
+      weight: 1,
+    },
+  ],
+};
+
+export function create(): PluginConfig {
+  return {
+    slug: dummyPluginSlug,
+    title: 'Dummy Plugin',
+    icon: 'folder-javascript',
+    description: 'A dummy plugin to test the cli.',
+    runner: async () => {
+      const itemCount = JSON.parse(
+        await readFile(join('src', 'items.json'), 'utf-8'),
+      ).length;
+      return [
+        {
+          ...dummyAudit,
+          slug: dummyAuditSlug,
+          score: itemCount < 10 ? itemCount / 10 : 1,
+          value: itemCount,
+        },
+      ];
+    },
+    audits: [dummyAudit],
+  };
+}
+
+export default create;

e2e/cli-e2e/project.json

@@ -11,22 +11,13 @@
         "lintFilePatterns": ["e2e/cli-e2e/**/*.ts"]
       }
     },
-    "e2e-old": {
+    "e2e": {
       "executor": "@nx/vite:test",
       "options": {
         "configFile": "e2e/cli-e2e/vite.config.e2e.ts"
       }
     }
   },
-  "implicitDependencies": [
-    "models",
-    "utils",
-    "core",
-    "cli",
-    "plugin-eslint",
-    "plugin-coverage",
-    "plugin-js-packages",
-    "react-todos-app"
-  ],
+  "implicitDependencies": ["cli"],
   "tags": ["scope:core", "scope:plugin", "type:e2e"]
 }