Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] development builds cmder.exe always overwrites the terminal emulator settings files. #2940

Open
4 tasks done
296951 opened this issue May 29, 2024 · 11 comments
Open
4 tasks done

Comments

@296951
Copy link

296951 commented May 29, 2024

Version Information

Cmder version:development
Operating system:Windows 11

Cmder Edition

Development branch.

Description of the issue

Title says it all.

How to reproduce

  1. Edit/Add a profile/task in Windows Terminal or ConEmu.
  2. Close Windows Terminal or ConEmu
  3. Run cmder.exe
  4. Profile Edits/Adds are lost.

Additional context

No response

Checklist

  • I have read the documentation.
  • I have searched for similar issues and found none that describe my issue.
  • I have reproduced the issue on the latest version of Cmder.
  • I am certain my issues are not related to ConEmu, Clink, or other third-party tools that Cmder uses.
@daxgames
Copy link
Member

Working on it...

@daxgames
Copy link
Member

I must have had an OLD Cmder.exe the currently compiled exe works fine.

@DRSDavidSoft
Copy link
Contributor

DRSDavidSoft commented May 30, 2024

So the profile creation is done using the launcher?

Quick q. would it also make sense to add the profile to the global WT itself in the mini versions as well... for people that don't want to include a duplicate WT on their machines BTW

@daxgames
Copy link
Member

daxgames commented May 30, 2024

So the profile creation is done using a launcher?

Yes - Always has even for ConEmu

Cmder.exe copies a Default ConEmu.xml or a settings.json if they do not exist.

Quick q. would it also make sense to add the profile to the global WT itself in the mini versions as well... for people that don't want to include a duplicate WT on their machines BTW

I don't understand the question. The cmder-mini distributions include either ConEmu or Windows Terminal depending in which distro is downloaded.

UNRELEASED - Cmder for Windows is micro compared to mini as it does not include a terminal emulator and uses native Cmd.exe/Powershell.exe shells pre-installed with Windows or Git Bash.

See PR #2942

@DRSDavidSoft
Copy link
Contributor

@daxgames "Micro" would be my pesonal favorite as it would include the core Cmder features (e.g. profiles & clink) and leave the terminal to the end-user

@daxgames
Copy link
Member

@DRSDavidSoft Cmder for Windows is just that EXCEPT it uses Cmd.exe, Powershell.exe, and bash.exe or mintty.exe. There is ZERO configuration to say launch these in ConEmu or Windows Terminal or ANY other terminal emulator.

@daxgames daxgames reopened this May 31, 2024
@daxgames daxgames changed the title [Bug] Windows Terminal builds cmder.exe always overwrites the %cmder_root%\vendor\windows-terminal\settings\settings.json with the default settings.json [Bug] development builds cmder.exe always overwrites the terminal emulator settings. May 31, 2024
@daxgames daxgames changed the title [Bug] development builds cmder.exe always overwrites the terminal emulator settings. [Bug] development builds cmder.exe always overwrites the terminal emulator settings files. May 31, 2024
@daxgames
Copy link
Member

This is worse than I originally thought. ConEmu is busted too.

@DRSDavidSoft
Copy link
Contributor

This is worse than I originally thought. ConEmu is busted too.

Is this issue only in dev branch or is master also affected?

@daxgames
Copy link
Member

I have not looked at master. I just looked at this again the other day I will look at master and get back to you.

I think it is ready to merge but let me put some more time into it.

@daxgames
Copy link
Member

@DRSDavidSoft This is not in master. The PR should be ready to merge if the latest commit builds. It builds and works for me locally.

@DRSDavidSoft
Copy link
Contributor

I still have to review the dev build, I'm assigning some tome to do so. Then we can be sure to merge develop with master. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants