Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support ECS service connect #283

Closed
wants to merge 2 commits into from
Closed

feat: support ECS service connect #283

wants to merge 2 commits into from

Conversation

jeffquinn-blr
Copy link

@jeffquinn-blr jeffquinn-blr commented Jul 23, 2024 •
edited
Loading

what

  • This adds support for ECS Service connect, which is already supported by terraform-aws-ecs-alb-service-task

why

  • Extend the module's functionality.
  • Support deployment of a webserver that depends on a separate ECS microservice (this configuration block needs to be defined to allow service connect client mode)

references

@jeffquinn-blr jeffquinn-blr requested review from a team as code owners July 23, 2024 14:14
@mergify mergify bot added the triage Needs triage label Jul 23, 2024
@mergify Mergify
Copy link

mergify bot commented Sep 19, 2024

💥 This pull request now has conflicts. Could you fix it @jeffquinn-blr? 🙏

@mergify mergify bot added the conflict This PR has conflicts label Sep 19, 2024
@mergify mergify bot closed this Sep 19, 2024
@mergify Mergify
Copy link

mergify bot commented Sep 19, 2024

This PR was closed due to inactivity and merge conflicts. 😭
Please resolve the conflicts and reopen if necessary.

@mergify mergify bot removed conflict This PR has conflicts triage Needs triage labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

@RoseSecurity RoseSecurity Awaiting requested review from RoseSecurity RoseSecurity is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffquinn-blr @jeffquinn-msk