-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.x #2
Comments
Hi - It was written for a specific customer in 2017 with a requirement for
Python2.
I'm not actively using PCAPNG anymore, but it could be easily upgraded.
Mostly the string functions, I think.
Alan
…On Mon, Oct 4, 2021 at 11:53 PM Craig McQueen ***@***.***> wrote:
I was really surprised to discover this Python package is 2.x only.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWBOBYN64Q3ILX5PEYD2ODUFKOGFANCNFSM5FLASZIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
See pcapng3 · PyPI. Maybe you could pull Python 3.x support from that (though its repo is in GitLab, not GitHub). |
Now that the Python project has sunset Python 2 (January 2020), arguably Python packages can drop support for Python 2.x and move entirely to 3.x. Would you accept a pull request that made this package 3.x-only? |
Sure. The unit tests are pretty complete, so if it passes those it should
be good.
…On Tue, Oct 5, 2021 at 3:53 PM Craig McQueen ***@***.***> wrote:
Now that the Python project has sunset Python 2 (January 2020), arguably
Python packages can drop support for Python 2.x and move entirely to 3.x.
Would you accept a pull request that made this package 3.x-only?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#2 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABWBOB6UVATD55JLOKOQQBLUFN6WTANCNFSM5FLASZIQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I was really surprised to discover this Python package is 2.x only.
The text was updated successfully, but these errors were encountered: