Detect .bb and .clj_kondo file extension as Clojure #42
Conversation
Since BitBake already claimed the `.bb` file extension before Babashka, we cannot override it in upstream Vim, hence we register an optional `after` ftdetect plugin for various unofficial Clojure file extensions. I'm not a fan of using `after` for this, so I may change it at a later date.
|
Thank you!
Ah yes, sorry I forgot about that. That explains the note I had on my local machine about maybe making this an optional toggle. I've pushed a small update to this PR to move detection of unofficial Clojure file extensions to an "after" Regarding if it matters that the BitBake syntax and indent files being loaded before the Clojure files matters, it doesn't. We override all those options. Unfortunately there's no easy way to prevent it either, especially not in Neovim (since they've replaced many Vimscript files with Lua ones).
Yes this is because there is a dedicated file in Vim which handles those. I'll update that when I next merge these changes upstream, but due to the BitBake clash I'll need to make sure it won't impact anything else first. I also noticed that we weren't including an XML option in the GVim file browse option, so I've included that too in this PR. |
|
I'll merge this now and make a note to update the README to mention how to enable/disable Babashka (and other unofficial Clj) file type detection (and that it requires this plugin to be installed). I'll also make a note to check and maybe update shebang detection for Babashka in upstream Vim. |
This should resolve issue #38.
I ran the Clojure program to update the syntax files but nothing was changed except the comment about the version of Java using with Clojure. I did have to make the
update-project!function not private to run the function as specified in contributiting guidelines.I didn't test the browsefilter because I don't use Windows or GTK.
I ran
lein testand got:I installed my changes as a plugin for Vim 9.0.2142 on macOS Sequoia 15.0.1 on Apple Silicon (M3 2024 Macbook air). Editing files with extension .bb and .clj_kondo are detected as
clojurefiles. The same is true with Neovim 0.10.2.I did notice that in a file without a filename extension but a shebang line, the filetype isn't set to
clojure.Another thing that I noticed is that .bb is a recognized as a
bitbakefiletype so the associated .vim scripts are loaded as reported by:scriptnames. I'm not sure if that affects the syntax highlighting and/or indent as I'm not quite up-to-speed with Clojure syntax.