-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[complexity-test] tune the included LLVM version to match Cilium minor release #674
Comments
@gentoo-root fyi |
Any drawbacks if we just stop updating the complexity-test image in stable branches? I guess there may be some improvements to the image itself (other than updating LLVM) that we need to pick in the CI? |
We would stop covering the patch bumps of the tested kernel versions. IIRC Cilium did have regressions in the past, due to backported verifier changes that caused programs to be rejected. |
Yeah, I agree, this is important, I saw it too: I can't upgrade to LLVM 18, because we need to pick some kernel patches, but the upgraded kernel causes regressions in the CI: cilium/cilium#33927 |
Background:
Cilium uses the
complexity-test
image to test the building & loading of various BPF datapath programs. For a specific minor version of Cilium, the image should use the corresponding LLVM version. With Cilium v1.16 we bumped the included LLVM fromv10
tov17
, and this commit pulled LLVM v17 into thecomplexity-test
image. Now pulling the latestcomplexity-test
image into CI for eg. Cilium v1.15 means that we would test with LLVM v17, even though Cilium v1.15 actually still uses LLVM v10 to build its BPF programs.Proposal:
Build Cilium minor-specific variants of
complexity-test
, which pull in the LLVM version of that minor release.The text was updated successfully, but these errors were encountered: