Add window title #34
Open
Add window title #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be up for merging this if it could be configurable. An opt-in option when you run choose. |
|
Nice, what do you think about the second commit? Have you experienced where the window goes behind a window? For me it only happens with chromium. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For window managers like Amethyst, the bundle id doesn't work, and the other identifier is a window title. This just adds a title to the window so it is easier to identify by applications.
I don't mind if you don't merge this, but I just thought to open a pull request. Amazing app you guys have developed, by the way. Extremely useful.