Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to disable SSL verification completely #53

Closed
andrewvc opened this issue Jul 19, 2016 · 11 comments
Closed

Add ability to disable SSL verification completely #53

andrewvc opened this issue Jul 19, 2016 · 11 comments

Comments

@andrewvc
Copy link
Contributor

Unfortunately :verify doesn't really skip all checks like curl -k does.

It'd be great to be able to have curl -k like behavior (Just get the data, ignore all SSL issues).

I don't see a way to do this as a user because configuring the connection factory a-la http://stackoverflow.com/questions/2703161/how-to-ignore-ssl-certificate-errors-in-apache-httpclient-4-0 isn't possible. It'd be great to add in a feature whereby that could be done. I'll try to submit a PR soon.

@andrewvc
Copy link
Contributor Author

This also goes to #52

@Yaiba782
Copy link

Hello hello
Is there any news about the ssl certificate validation option ?
How can I disable it ?

@yoavsradware
Copy link

hey all , is there something new ?

@rsk0
Copy link

rsk0 commented Oct 4, 2017

Hate to me-too, but I'd love to have this functionality. (And exposed via http_poller.)

@cheald
Copy link
Owner

cheald commented Oct 6, 2017

Oh man, I keep meaning to get to this, but I've just had zero bandwidth lately. If anyone wants to take a stab at this, I'd love to accept a PR. Otherwise, I'll try to get to it soon!

@cheald
Copy link
Owner

cheald commented Oct 6, 2017

Can someone provide a test case that illustrates which issues we're trying to solve here? I'm having a hard time generating a spec which causes Manticore's behavior to break.

@ralph-tice
Copy link

try an expired certificate, or one without a hostname specified

@cheald
Copy link
Owner

cheald commented May 28, 2018

Expired cert doesn't cause any problems on Ubuntu 18.04. I still can't find a way to repro this one :(

@moataz-py
Copy link

moataz-py commented Jan 14, 2021

Hello I have modified multicore client file to make the default action is ALLOW ALL
I know it's not clean but I am not ruby developer to make it clean
it solved host name check in SSL certificate issue
/usr/share/logstash/vendor/bundle/jruby/2.5.0/gems/manticore-0.7.0-java/lib/manticore/client.rb
image

@111andre111
Copy link

Seems like these 2 PRs count into that direction meanwhile, would this already close this issue:
#99
#100

@kares
Copy link
Collaborator

kares commented Jan 18, 2022

verify: :disabled has been revised to ignore verification completely (#100 and #101),
the (legacy) verify: false case keeps working as before - still does a hostname check.

@kares kares closed this as completed Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants