-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform AWS Provider 3.0 compatibility #322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mbarrien
commented
Jul 6, 2021
•
edited
Loading
edited
- Internally use the new aws-acm-certificate module that is compatible with TF AWS Provider 3.0 (in aws-cloudfront-domain-redirect and aws-single-page-static-site)
- Adapt to the new ARN format return by aws_cloudwatch_log_group arn, due to removal of arn wildcard suffix: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-3-upgrade#resource-aws_cloudwatch_log_group
- aws-single-page-static-site no longer strip off trailing dot from data.aws_route53_zone name, since new provider version guarantees its removal: https://registry.terraform.io/providers/hashicorp/aws/latest/docs/guides/version-3-upgrade#removal-of-trailing-period-in-name-argument-1
- aws-single-page-static-site make custom_error_response_codes nullable, default from internal implementation.
- Export bucket name from github-webhooks-to-s3
- Remove Terraform provider version restrictions
cziie
reviewed
Jul 6, 2021
mbarrien
force-pushed
the
tf-aws-3.0
branch
2 times, most recently
from
July 6, 2021 09:54
a74e3e6
to
7411209
Compare
cziie
reviewed
Jul 6, 2021
edulop91
reviewed
Jul 6, 2021
edulop91
reviewed
Jul 6, 2021
mbarrien
force-pushed
the
tf-aws-3.0
branch
2 times, most recently
from
July 7, 2021 09:15
3fb729e
to
4bcb406
Compare
edulop91
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.