Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement Request: Support configuration of "encryption.blacklisted-algorithms". #791

Open
Logiar opened this issue Nov 24, 2023 · 2 comments

Comments

@Logiar
Copy link

Logiar commented Nov 24, 2023

Enhancement Objective

Introduce configurable options in the plugin for managing encryption.blacklisted-algorithms in the SimpleSAMLphp library. This includes enabling the override of default denylisted algorithms for compatibility purposes.

Background

The integration of SimpleSAMLphp within the Moodle plugin includes a default denylisted encryption algorithm. While this enhances security, it can create compatibility issues with systems that still use this algorithm.

Proposed Solution

  1. Configurable Overrides: Add settings to allow administrators to unblock the default denylisted algorithm when needed for compatibility.
  2. Custom Denylisting Capability: Enable administrators to specify additional denylisted encryption algorithms.
@danmarsden
Copy link
Member

Can we please change the language used in the saml2 code to 'denylist' instead of 'blacklist". Both variable names in code and the user facing strings. (I didn't look closely at simplesaml but you probably can't change the var names used by simplesaml, just the ones we can control in the saml2 code.)

Thanks!

@Logiar
Copy link
Author

Logiar commented Nov 24, 2023

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants