Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P1-add proper instructions in readme #39

Open
sahel-sh opened this issue Jan 23, 2024 · 4 comments
Open

P1-add proper instructions in readme #39

sahel-sh opened this issue Jan 23, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@sahel-sh
Copy link
Member

No description provided.

@sahel-sh sahel-sh added the documentation Improvements or additions to documentation label Jan 23, 2024
@sahel-sh sahel-sh self-assigned this Jan 28, 2024
@sahel-sh sahel-sh changed the title add proper instructions in readme P1-add proper instructions in readme Jan 29, 2024
@AndreSlavescu
Copy link
Contributor

interested

@sahel-sh
Copy link
Member Author

@AndreSlavescu thank you for your interest.
We can work on this together. As a first draft we should aim for including snippets from demo, but step by step. #retrieve in its own section and #rerank in its own, then we can add response analysis, eval, writing results, etc.

@sahel-sh
Copy link
Member Author

@AndreSlavescu I think if you could add a short paragraph on package installation, and running one of the demos, we can mark this as complete:
something like:

try it out:

install

pip..

run demo:

python ...

@sahel-sh
Copy link
Member Author

sahel-sh commented Feb 6, 2024

From our chat:

I think we need instructions for pip install too in the demo section

and we should replace the end-2-end demo or keep it as an alternative or something, the main story should match our demos, please use the demo with prebuilt index

We need another section on testing, some of our import path need the package installed as editable, add the command for using unittest to discover the tests

and maybe a high level readme in each subpackage describing it
. the package readmes can point to code in under the demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants