Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: Moving to latest version of @typescript-eslint/utils #13

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dubzzz
Copy link

@dubzzz dubzzz commented May 14, 2024

Not being on the latest version of @typescript-eslint/utils prevents users to easily move to the v9 of eslint. By moving away from @typescript-eslint/experimental-utils and replacing it by its modern package we unlock users wanting to go for eslint v9. If the change is acceptable for you, I'll do he same in eslint-plugin-rxjs.

It's a breaking change! So probably worth a major bump.

Not breakage expected from experimetal-utils v5 to utils v5. But the move is recommended by https://www.npmjs.com/package/@typescript-eslint/experimental-utils.
@dubzzz dubzzz changed the title Moving to latest version of @typescript-eslint/utils BREAKING CHANGE: Moving to latest version of @typescript-eslint/utils May 14, 2024
@dubzzz
Copy link
Author

dubzzz commented May 21, 2024

@cartant Any chance it gets accepted and merged?

@joecotton-jamf
Copy link

Upvote, this needs to be merged.

The use of v5 for utils also causes peer dependency issues with the latest version of @angular-eslint/eslint-plugin

@tonyganchev
Copy link

One more upvote. We're completely blocked on our eslint 9 migration because of this.

@@ -4,7 +4,7 @@
"url": "https://github.com/cartant/eslint-etc/issues"
},
"dependencies": {
"@typescript-eslint/experimental-utils": "^5.0.0",
"@typescript-eslint/utils": "^7.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, any reason not to go to v8 (and eslint v9)?

@michaelfaith
Copy link

@cartant would you support this PR updating to @typescript-eslint v8 / eslint v9?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants