-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Aframe 1.5.0 compatible (remove conflicts with new core component grabbable) #238
Comments
maybe this should be changed in aframe? |
I don't think @dmarcos will want to change the name, the component is included in an aframe release already. I didn't test, but you should be able to use the following to resolve the issue: <script src="https://aframe.io/releases/1.5.0/aframe.min.js"></script>
<script>
delete AFRAME.components["grabbable"];
</script>
<script src="https://unpkg.com/super-hands@^3.0.3/dist/super-hands.min.js"></script> We probably need to rename |
any updates on this? 🙏 |
@jonarnaldo Do the above code snippet works for you? I'm not using this component, so I won't work it. But someone can make a PR if we agree on something here. |
I'd also recommend PS: I'd also appreciate @wmurphyrd's view on the topic as he's been thinking on this quite a bit. |
jeezus, it took me forever to eventually get to this page, after trying everything to fix my code. |
[vincentfretin's solution works 100% I just tested it. It should be at least AT LEAST added to the Super Hands documentation including on the read me underneath Installation, UNTIL we have a new name to replace grabbable, like graspable <script src="https://aframe.io/releases/1.5.0/aframe.min.js"></script> <script> delete AFRAME.components["grabbable"]; </script> <script src="https://unpkg.com/super-hands@^3.0.3/dist/super-hands.min.js"></script> |
PR welcome to add it to the README, thanks! |
It just occurred to me that someone could write a my-super-hands component also that somehow replaces the word grabbable with something else. |
It seems the README is now updated, via #239. |
In Aframe 1.5.0 release there was a component added to core called "grabbable". This leads to conflicts with the component of super-hands, which has the same name.
The text was updated successfully, but these errors were encountered: