Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add SIMD128 support in the interpreters #3803

Open
jammar1 opened this issue Sep 19, 2024 · 3 comments
Open

[RFC] Add SIMD128 support in the interpreters #3803

jammar1 opened this issue Sep 19, 2024 · 3 comments

Comments

@jammar1
Copy link

jammar1 commented Sep 19, 2024

Feature

Add support for the WASM SIMD opcodes in the interpreters.
For my use case I imagine I would use only ARM NEON intrinsics that can run on ARMv7 processors.
I imagine I can create some stub functions and then implement them for arm and keep x86 disabled for now.

Benefit

Ability to run code that uses the SIMD 128 opcodes in the interpreters where AOT is not possible.

Implementation

I've implemented a few of the SIMD opcodes already as a PoC but I'm expecting to work through the list and add them all.

Alternatives

@loganek
Copy link
Collaborator

loganek commented Sep 20, 2024

Thanks @jammar1 . Do you think it'd be good to setup a dev branch so you can post incremental Pull requests or you'd rather just make one big request with all the opcodes implemented? cc: @wenyongh

@wenyongh
Copy link
Contributor

@loganek, @jammar1 Maybe using a dev branch is better so that we can do more test before merging the feature to main branch? I created a new branch dev/simd_for_interp: https://github.com/bytecodealliance/wasm-micro-runtime/tree/dev/simd_for_interp.

@jammar1
Copy link
Author

jammar1 commented Sep 20, 2024

Agree with using a dev branch. I imagine I will work through each of the SIMD test suites and raise a PR for each opcode in the block's here: core/iwasm/interpreter/wasm_opcode.h.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

5 participants
@loganek @wenyongh @jammar1 and others