Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClientDevice shouldn't require reference ownership of Client #680

Open
qdot opened this issue Dec 28, 2022 · 0 comments
Open

ClientDevice shouldn't require reference ownership of Client #680

qdot opened this issue Dec 28, 2022 · 0 comments
Labels
bug Something is broken client Anything relating to clients, including connectors

Comments

@qdot
Copy link
Member

qdot commented Dec 28, 2022

Making the ClientDevice own the client is silly. We have equality methods on devices for reasons I'm not really sure of, and the ClientDevice will already have one reference to the client via the connector sending closure. We should depend on that closure to report if the client is disconnected.
@qdot qdot added bug Something is broken client Anything relating to clients, including connectors labels Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something is broken client Anything relating to clients, including connectors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@qdot