-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/CD: Wait for Docker port to be open #1932
Comments
Hello @krancour , I would like to give it a try. |
All yours. |
Hello Sir @krancour, Can I takeover this issue? I have bash scripting experience and I feel confident in putting together a working script. |
I've made a new draft commit on this issue, please review changes. |
I'm no longer a maintainer for this project, but also, as an fyi, this project is currently being considered for archival. |
Ok Sir, No problem. I'm happy to have attempted to contribute :) |
Our CI/CD processes (see
.brigade/brigade.ts
) build multi-arch Docker images using "Docker in Docker." The primary container for each job runs the Docker client while the Docker server runs in a sidecar.Currently, the image build processes use a
sleep
before proceeding with adocker buildx ...
This allows the sidecar a grace period to start before the build proceeds. Often this delays builds longer than necessary. Sometimes it leads to failures because resource demand in the cluster meant the Docker server in the sidecar was slow to start.This issue suggests modifying the process to wait only as long as needed (up to some limit -- 90 seconds maybe) for port 2375 to actually start accepting requests.
Some very small amount of research will be required on how best to achieve, this, but it is easily accomplished with
nc
or even pure bash.Note: Several other repos in the @brigadecore org would benefit from a similar change.
The text was updated successfully, but these errors were encountered: