Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Auth: Username(s) as allowed organization(s)? #1573

Open
vdice opened this issue Aug 17, 2021 · 1 comment
Open

GitHub Auth: Username(s) as allowed organization(s)? #1573

vdice opened this issue Aug 17, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@vdice
Copy link
Contributor

vdice commented Aug 17, 2021

I'm wondering if we can support use of GitHub username(s) as values under the github.allowedOrganizations field in Brigade's Helm chart -- and Brigade would limit authentication to users with those usernames only.

I'd actually done this successfully a few months back, but it appears to no longer work. (Now attempts lead to: Could not authenticate the request: User is not a member of any allowed GitHub organizations)

Admittedly, it was already kind of a 'hack'/unintended feature. If we do want to enable such functionality, I would understand adding in the form of a new field, say, allowedUsers.

@vdice vdice added the 2.0 label Aug 17, 2021
@krancour krancour added this to the 2.0.0-beta.3 milestone Aug 17, 2021
@krancour krancour added the enhancement New feature or request label Aug 17, 2021
@krancour
Copy link
Contributor

Labeling this as an enhancement (as opposed to a bug) because, as you've noted, the fact that this ever worked the way it once did was a quirk and wasn't by design.

This time around, we'll design for it.

@krancour krancour modified the milestones: 2.0.0-beta.3, 2.0.0-beta.4 Sep 16, 2021
@krancour krancour removed this from the 2.0.0-beta.4 milestone Oct 26, 2021
@krancour krancour removed the 2.0 label Dec 2, 2021
@krancour krancour added this to the v2.1.0 milestone Dec 2, 2021
@krancour krancour modified the milestones: v2.1.0, v2.2.0, v2.3.0 Dec 14, 2021
@krancour krancour modified the milestones: v2.3.0, v2.4.0 Feb 4, 2022
@krancour krancour modified the milestones: v2.4.0, v2.5.0 Mar 18, 2022
@krancour krancour removed this from the v2.5.0 milestone Apr 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants