Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to ignore files #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

obenjiro
Copy link

fixes #87

@brentlintner
Copy link
Owner

@AiBoy thanks for the PR and feature! :-)

This looks solid. Thanks as well for the tests and kudos for picking ignore- I was thinking the same!

Feature wise:

  • Unless I am wrong, we should probably change glob (i.e. in CLI options help) to pattern, given that node-ignore technically supports gitignore spec vs exclusively glob style?
  • Have a way to support multiple paths (perhaps: -i *.ts,foo)?

Style wise (I can always do this if it's annoying):

  • No semicolons in src
  • Ideally make use of -d by default for test fixture output
  • Don't need to commit lib (no worries if annoying to remove)

Thoughts? :-)

@obenjiro
Copy link
Author

@brentlintner You're the boss :) I will fix this today or tomorrow and return back to you for additional feedback.

PS: about committing "lib" folder. Mb we should add it to gitignore then? Should I do it or not?

@brentlintner
Copy link
Owner

@AiBoy ok cool. :-)

As for adding lib to .gitignore I had it there before, but once I started committing lib files upon each release then no matter what lib files would show up as unstaged. :-S If you know/find an ideal way, then awesome! No worries if not. :-)

@cdierkens
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ignoring files/dirs via the CLI
3 participants