Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #80

Open
Geal opened this issue Jan 6, 2024 · 1 comment
Open

Code cleanup #80

Geal opened this issue Jan 6, 2024 · 1 comment

Comments

@Geal
Copy link
Contributor

Geal commented Jan 6, 2024

the library has been written in a way that is not very idiomatic, mainly through using types from the vavr project. This has helped us gain confidence in the implementation by following closely the rust implementation, but it is now slowing us down. Those types should be replaced gradually, where it makes sense (not a thoughtless search and replace):

  • Either -> using exceptions. This in particular should clean up a lot of the code
  • option: nullable type?
  • tuples -> record objects
@murdos
Copy link
Contributor

murdos commented Apr 26, 2024

  • option -> Optional?

BTW using record objects (which is a good idea IMO) would require using java 17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants