Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Global-exports to require React and support node modules #127

Closed
wants to merge 1 commit into from

Conversation

Deraen
Copy link

@Deraen Deraen commented Aug 18, 2017

This is similar to reagent-project/reagent#306
https://github.com/reagent-project/reagent/blob/master/CHANGELOG.md#080-alpha1-2017-07-31

I'm opening PR's on other related projects also:

It is possible further changes to ClojureScript will make this change (partially) unnecessary: https://dev.clojure.org/jira/browse/CLJS-2331

Build causes lots of warnings:

WARNING: No such namespace: react, could not locate react.cljs, react.cljc, or JavaScript source providing "react" at line 37 example_src/devdemos/om_next.cljs
WARNING: Use of undeclared Var react/Component at line 37 example_src/devdemos/om_next.cljs

It is probably these are caused by problems in Om.

Some views work on browser, but there are some errors on console and at least om.next card is empty:

image

@bhauman
Copy link
Owner

bhauman commented Oct 25, 2017

Closing because this should be resolved.

@bhauman bhauman closed this Oct 25, 2017
@Deraen
Copy link
Author

Deraen commented Oct 25, 2017

How so?

Devcards (and sablono) is still referring to js/React so it won't work when using React from Node package.

@bhauman
Copy link
Owner

bhauman commented Oct 25, 2017 via email

@bhauman bhauman reopened this Oct 25, 2017
@bhauman
Copy link
Owner

bhauman commented Sep 5, 2018

this is fixed with 4881652

@bhauman bhauman closed this Sep 5, 2018
@lfborjas lfborjas mentioned this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants