fix: write config to json #71

sakulstra · 2023-03-16T10:40:32Z

Changes:

emit json (some bugs due to chore(deps): bump lib/aave-address-book from e1faa69 to 75184f3 #244, but fine)
snapshot oracle & current price
snapshot a/s/v impl on v2 as well
snapshot poolImpl / configImpl / pooldataprovider

Todo (can be done in different pr) as blocked by:

~~writeJson for Array of Objects foundry-rs/forge-std#244~~ (worked around with different structure)
fix(cheatcodes): Make serializeString always serialize values into a string, add serializeJson cheatcode foundry-rs/foundry#4602 (this currently makes it cumbersome to read via js)
fileRoot cheatcode foundry-rs/foundry#4577 (making distribution of a utility hard, as needs to be backwards compatible to not always break systems)
provide utility to diff & generate human readable report

github-actions · 2023-03-16T10:41:32Z

Foundry report

forge 0.2.0 (5182f43 2023-03-24T00:12:06.292809241Z)

Build log

installing solc version "0.8.19"
Successfully installed solc 0.8.19
Compiling 132 files with 0.8.19
Solc 0.8.19 finished in 44.66s
Compiler run successful (with warnings)
�[33mwarning[9302]: �[0m�[33mWarning: Return value of low-level calls not used.
   --> src/test/crosschainforwarders/ArbitrumCrossChainForwarderTest.t.sol:140:5:
    |
140 |     ARBITRUM_BRIDGE_EXECUTOR.call(payload);
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

�[0m

| Contract                           | Size (kB) | Margin (kB) |
|------------------------------------|-----------|-------------|
| AaveGovernanceV2                   | 0.272     | 24.304      |
| AaveMisc                           | 0.086     | 24.49       |
| AaveV2Avalanche                    | 0.086     | 24.49       |
| AaveV2AvalancheAssets              | 0.086     | 24.49       |
| AaveV2Ethereum                     | 0.086     | 24.49       |
| AaveV2EthereumAMM                  | 0.086     | 24.49       |
| AaveV2EthereumAMMAssets            | 0.086     | 24.49       |
| AaveV2EthereumArc                  | 0.086     | 24.49       |
| AaveV2EthereumAssets               | 0.086     | 24.49       |
| AaveV2Fuji                         | 0.086     | 24.49       |
| AaveV2FujiAssets                   | 0.086     | 24.49       |
| AaveV2Goerli                       | 0.086     | 24.49       |
| AaveV2GoerliAssets                 | 0.086     | 24.49       |
| AaveV2Mumbai                       | 0.086     | 24.49       |
| AaveV2MumbaiAssets                 | 0.086     | 24.49       |
| AaveV2Polygon                      | 0.086     | 24.49       |
| AaveV2PolygonAssets                | 0.086     | 24.49       |
| AaveV3Arbitrum                     | 0.086     | 24.49       |
| AaveV3ArbitrumAssets               | 0.086     | 24.49       |
| AaveV3ArbitrumGoerli               | 0.086     | 24.49       |
| AaveV3ArbitrumGoerliAssets         | 0.086     | 24.49       |
| AaveV3ArbitrumRatesUpdates070322   | 4.554     | 20.022      |
| AaveV3Avalanche                    | 0.086     | 24.49       |
| AaveV3AvalancheAssets              | 0.086     | 24.49       |
| AaveV3AvalancheCollateralUpdate    | 3.011     | 21.565      |
| AaveV3AvalancheRatesUpdates070322  | 5.119     | 19.457      |
| AaveV3ConfigEngine                 | 20.905    | 3.671       |
| AaveV3Ethereum                     | 0.086     | 24.49       |
| AaveV3EthereumAssets               | 0.086     | 24.49       |
| AaveV3EthereumMockCapUpdate        | 2.92      | 21.656      |
| AaveV3EthereumMockCustomListing    | 3.919     | 20.657      |
| AaveV3Fantom                       | 0.086     | 24.49       |
| AaveV3FantomAssets                 | 0.086     | 24.49       |
| AaveV3FantomTestnet                | 0.086     | 24.49       |
| AaveV3FantomTestnetAssets          | 0.086     | 24.49       |
| AaveV3Fuji                         | 0.086     | 24.49       |
| AaveV3FujiAssets                   | 0.086     | 24.49       |
| AaveV3Goerli                       | 0.086     | 24.49       |
| AaveV3GoerliAssets                 | 0.086     | 24.49       |
| AaveV3GoerliGho                    | 0.086     | 24.49       |
| AaveV3GoerliGhoAssets              | 0.086     | 24.49       |
| AaveV3Harmony                      | 0.086     | 24.49       |
| AaveV3HarmonyAssets                | 0.086     | 24.49       |
| AaveV3Mumbai                       | 0.086     | 24.49       |
| AaveV3MumbaiAssets                 | 0.086     | 24.49       |
| AaveV3Optimism                     | 0.086     | 24.49       |
| AaveV3OptimismAssets               | 0.086     | 24.49       |
| AaveV3OptimismGoerli               | 0.086     | 24.49       |
| AaveV3OptimismGoerliAssets         | 0.086     | 24.49       |
| AaveV3OptimismMockRatesUpdate      | 3.254     | 21.322      |
| AaveV3OptimismRatesUpdates070322   | 4.133     | 20.443      |
| AaveV3Polygon                      | 0.086     | 24.49       |
| AaveV3PolygonAssets                | 0.086     | 24.49       |
| AaveV3PolygonBorrowUpdate          | 3.005     | 21.571      |
| AaveV3PolygonMockListing           | 3.731     | 20.845      |
| AaveV3PolygonPriceFeedUpdate       | 2.856     | 21.72       |
| AaveV3PolygonRatesUpdates070322    | 5.858     | 18.718      |
| AaveV3Sepolia                      | 0.086     | 24.49       |
| AaveV3SepoliaAssets                | 0.086     | 24.49       |
| Address                            | 0.086     | 24.49       |
| AddressAliasHelper                 | 0.086     | 24.49       |
| BridgeExecutorHelpers              | 0.086     | 24.49       |
| ConfiguratorInputTypes             | 0.086     | 24.49       |
| CrosschainForwarderArbitrum        | 2.246     | 22.33       |
| CrosschainForwarderOptimism        | 1.689     | 22.887      |
| CrosschainForwarderPolygon         | 1.435     | 23.141      |
| DataTypes                          | 0.086     | 24.49       |
| DefaultReserveInterestRateStrategy | 2.923     | 21.653      |
| DeployEngineArbLib                 | 0.086     | 24.49       |
| DeployEngineAvaLib                 | 0.086     | 24.49       |
| DeployEngineEthLib                 | 0.086     | 24.49       |
| DeployEngineOptLib                 | 0.086     | 24.49       |
| DeployEnginePolLib                 | 0.086     | 24.49       |
| DeployRatesFactoryArbLib           | 0.086     | 24.49       |
| DeployRatesFactoryAvaLib           | 0.086     | 24.49       |
| DeployRatesFactoryEthLib           | 0.086     | 24.49       |
| DeployRatesFactoryLib              | 0.086     | 24.49       |
| DeployRatesFactoryOptLib           | 0.086     | 24.49       |
| DeployRatesFactoryPolLib           | 0.086     | 24.49       |
| EngineFlags                        | 0.086     | 24.49       |
| Errors                             | 4.392     | 20.184      |
| FxChild                            | 1.039     | 23.537      |
| FxRoot                             | 0.811     | 23.765      |
| GovHelpers                         | 0.086     | 24.49       |
| MockExecutor                       | 5.755     | 18.821      |
| PayloadWithEmit                    | 0.15      | 24.426      |
| PercentageMath                     | 0.086     | 24.49       |
| ProxyHelpers                       | 0.086     | 24.49       |
| ReserveConfiguration               | 0.171     | 24.405      |
| StdInvariant                       | 2.038     | 22.538      |
| StdStyle                           | 0.086     | 24.49       |
| V3RateStrategyFactory              | 9.279     | 15.297      |
| WadRayMath                         | 0.086     | 24.49       |
| console                            | 0.086     | 24.49       |
| console2                           | 0.086     | 24.49       |
| stdError                           | 0.591     | 23.985      |
| stdJson                            | 0.086     | 24.49       |
| stdMath                            | 0.086     | 24.49       |
| stdStorage                         | 0.086     | 24.49       |
| stdStorageSafe                     | 0.086     | 24.49       |

Test error

❌

No files changed, compilation skipped
�[2m2023-03-24T10:16:45.568374Z�[0m �[31mERROR�[0m �[2msharedbackend�[0m�[2m:�[0m Failed to send/recv `basic` �[3merr�[0m�[2m=�[0mGetAccount(0x5615deb798bb3e4dfa0139dfa1b3d433cc23b72f, 
�[31m(code: -32000, message: missing trie node 66fcb55f3a5c57bf06eb2f631f7a91d309e4b3d8c1f3bc2b403cecf14700e12e (path ) <nil>, data: None)�[0m) �[3maddress�[0m�[2m=�[0m0x5615deb798bb3e4dfa0139dfa1b3d433cc23b72f

Running 1 test for src/test/GovTest.t.sol:GovernanceTest
�[32m[PASS]�[0m testCreateProposal() (gas: 532556)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 315.79ms
�[2m2023-03-24T10:16:45.676840Z�[0m �[31mERROR�[0m �[2msharedbackend�[0m�[2m:�[0m Failed to send/recv `basic` �[3merr�[0m�[2m=�[0mGetAccount(0x5615deb798bb3e4dfa0139dfa1b3d433cc23b72f, 
�[31m(code: -32000, message: missing trie node 66fcb55f3a5c57bf06eb2f631f7a91d309e4b3d8c1f3bc2b403cecf14700e12e (path ) <nil>, data: None)�[0m) �[3maddress�[0m�[2m=�[0m0x5615deb798bb3e4dfa0139dfa1b3d433cc23b72f
�[2m2023-03-24T10:16:45.800952Z�[0m �[31mERROR�[0m �[2msharedbackend�[0m�[2m:�[0m Failed to send/recv `basic` �[3merr�[0m�[2m=�[0mGetAccount(0xa4b000000000000000000073657175656e636572, 
�[31m(code: -32000, message: missing trie node 66fcb55f3a5c57bf06eb2f631f7a91d309e4b3d8c1f3bc2b403cecf14700e12e (path ) <nil>, data: None)�[0m) �[3maddress�[0m�[2m=�[0m0xa4b000000000000000000073657175656e636572

sakulstra · 2023-03-16T14:20:54Z

There's currently an issue in foundry related to array serialization foundry-rs/forge-std#244 blocking this pr a little.

fix: write config to json

70958bf

feat: config snapshot v2

e2af9ff

sakulstra added 10 commits March 16, 2023 15:34

fix: reenable strategies

c9d622f

fix: emit json

b5f6b9f

feat: add oracle & latest answer

3fb1ca0

fix: reformat to workaround bug

3cf8222

feat: serialize chainId

4231582

feat: also snapshot pool config

f58ebea

fix: diff the json

288a42a

fix: upgrade everything

8b9847e

Merge branch 'master' into feat/config-snapshot-v2

7db6f9e

fix: cahnge diff to md again

4fe27e1

eboadom approved these changes Mar 24, 2023

View reviewed changes

sakulstra merged commit 0a77460 into master Mar 26, 2023

sakulstra deleted the feat/config-snapshot-v2 branch March 26, 2023 12:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: write config to json #71

fix: write config to json #71

sakulstra commented Mar 16, 2023 •

edited

Loading

github-actions bot commented Mar 16, 2023 •

edited

Loading

sakulstra commented Mar 16, 2023

fix: write config to json #71

fix: write config to json #71

Conversation

sakulstra commented Mar 16, 2023 • edited Loading

github-actions bot commented Mar 16, 2023 • edited Loading

sakulstra commented Mar 16, 2023

sakulstra commented Mar 16, 2023 •

edited

Loading

github-actions bot commented Mar 16, 2023 •

edited

Loading