Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services/s3: Migrate to aws-sdk-go-v2: Authenticating requests using query parameters #862

Open
2 tasks
JinnyYi opened this issue Oct 13, 2021 · 1 comment
Open
2 tasks

services/s3: Migrate to aws-sdk-go-v2: Authenticating requests using query parameters #862

JinnyYi opened this issue Oct 13, 2021 · 1 comment

Comments

@JinnyYi
Copy link
Contributor

JinnyYi commented Oct 13, 2021

Authenticating Requests: Using Query Parameters

Comparison

  • aws-sdk-go: It provides xxxRequest() to generate a "aws/request.Request" representing the client's request for almost all the operations. Then for query string authentication, we can use Presign to get the request's signed URL.
  • aws-sdk-go-v2: PresignClient represents the presign url client. And only PresignGetObject/PresignPutObject/PresignHeadObject/PresignUploadPart are provided.

When migrating to aws-sdk-go-v2, is it possible to provide services equivalent to the current version on authenticating requests? More specifically, how to implement MultipartHTTPSigner and QuerySignHTTPDelete?

Steps

  • New s3.PresignClient with s3.PresignOptions
  • Figure out whether more interfaces can support authentication with query parameters.
@Xuanwo Xuanwo changed the title Migrate to aws-sdk-go-v2: Authenticating requests using query parameters services/s3: Migrate to aws-sdk-go-v2: Authenticating requests using query parameters Oct 15, 2021
@Xuanwo Xuanwo transferred this issue from beyondstorage/go-service-s3 Oct 15, 2021
@BeyondRobot BeyondRobot mentioned this issue Oct 18, 2021
Closed
@Xuanwo Xuanwo moved this to Backlog in BeyondStorage Oct 18, 2021
@Xuanwo Xuanwo removed this from BeyondStorage Oct 18, 2021
@JinnyYi
Copy link
Contributor Author

JinnyYi commented Oct 21, 2021

Maybe we need support from upstream: aws/aws-sdk-go-v2#1469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JinnyYi