Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix C/C++ source-incompatibility in cl_manycore_regression.h #645

Open
drichmond opened this issue Nov 12, 2020 · 0 comments
Open

Fix C/C++ source-incompatibility in cl_manycore_regression.h #645

drichmond opened this issue Nov 12, 2020 · 0 comments
Labels
Low-Level API Regression

Comments

@drichmond
Copy link
Collaborator

We have #ifdef __cplusplus in several places to account for the use of standard library features that exist within C, but are in the global namespace.

In the long run, we should move these into their own cl_manycore_regression.cpp/c source file and use namespaces correctly (i.e. not in a header file).

See comments in #644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Low-Level API Regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@drichmond