Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in
bsg_two_fifo.sv
might not be necessary, however I found that without it thehead_r
andtail_r
pointers would no longer be equal, causing an invalid state for the FIFO.basejump_stl/bsg_dataflow/bsg_two_fifo.sv
Line 74 in 9322a57
I am also curious how to make the
allow_enq_deq_on_full_p
inbsg_two_fifo_wrapper potentially.sv
be something that can be properly parameterized, allowing both the normal and passthrough configurations to be tested.