Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bsg_fifo_1r1w_rolly, bsg_fifo_1r1w_store_and_forward #602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Yuan-Mao
Copy link
Contributor

This PR adds modules related to bsg_fifo_1r1w_rolly and bsg_fifo_1r1w_store_and_forward.
This PR also adds random tests with covergroup for bsg_fifo_1r1w_rolly and bsg_fifo_1r1w_store_and_forwardin under testing/.

@Yuan-Mao Yuan-Mao changed the title Add bsg_fifo_1r1w_rolly, bsg_fifo_1r1w_store_and_forward [WIP] Add bsg_fifo_1r1w_rolly, bsg_fifo_1r1w_store_and_forward Oct 19, 2022
Copy link
Contributor

@taylor-bsg taylor-bsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like you have three modules where you could have 1? I am a little unclear on hardened vs. unhardened. Seems like you are using a synchronous 1r1w in one case and an async in the other case? Can you just pass in a parameter and have a single code base or are there a lot of differences?

@dpetrisko
Copy link
Contributor

I think the hardened vs unhardened is inspired by:
https://github.com/bespoke-silicon-group/basejump_stl/blob/master/bsg_dataflow/bsg_fifo_1r1w_small_hardened.v
https://github.com/bespoke-silicon-group/basejump_stl/blob/master/bsg_dataflow/bsg_fifo_1r1w_small_unhardened.v

I don't remember the tradeoffs @gaozihou considered when making these two modules. When would it be preferable to have "unhardened" as the synchronous RAM can either be hardened or soft?

@Yuan-Mao Yuan-Mao changed the title [WIP] Add bsg_fifo_1r1w_rolly, bsg_fifo_1r1w_store_and_forward Add bsg_fifo_1r1w_rolly, bsg_fifo_1r1w_store_and_forward Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants