Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opening up the ServerDefinition to all languages #339

Open
payne911 opened this issue Sep 26, 2023 · 4 comments
Open

Opening up the ServerDefinition to all languages #339

payne911 opened this issue Sep 26, 2023 · 4 comments

Comments

@payne911
Copy link
Contributor

It would be great if we wouldn't have to exhaustively declare all supported file types in the ServerDefinition.

@nixel2007
Copy link
Contributor

You can add a property in your plugin and make it configurable by end user

@payne911
Copy link
Contributor Author

But then the end user would themselves have to list every single individual extension they want to support ?

@nixel2007
Copy link
Contributor

Yes. Also there are file watches created for files with this extensions so plugin can handle file modifications and send events to the language server.
Why do you need to register all extensions? Is your language server a generic one, which eally can handle any file, and not tied to any programming language?

@payne911
Copy link
Contributor Author

payne911 commented Oct 8, 2023

Is your language server a generic one, which eally can handle any file, and not tied to any programming language?

No, but it's annoying to have to maintain a list of the 50+ extensions we support. The extensions we don't support are somewhat rare and usually wouldn't exist within our company's repository so it's safe to assume that it would indeed handle pretty much any file opened.

... but yes, obviously the better thing to do is indeed to list each extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants