Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bal new command not working for few project-names #301

Closed
LakshanWeerasinghe opened this issue Jun 13, 2023 · 9 comments · Fixed by #339
Closed

Bal new command not working for few project-names #301

LakshanWeerasinghe opened this issue Jun 13, 2023 · 9 comments · Fixed by #339

Comments

@LakshanWeerasinghe
Copy link

Description:
$subject

Steps to reproduce:

bal new dist
bal new update

Affected Versions:
2201.5.0

@HeetVekariya
Copy link

@keizer619 @MohamedSabthar I would like to work on this issue as it is good first issue, can you please elaborate on what exact changes i have to do, so it will be easy for me to make.

@HeetVekariya
Copy link

@keizer619 can you please explain me the issue, such that i can start work on it.

@HeetVekariya
Copy link

HeetVekariya commented Oct 14, 2023

@keizer619 i am not clear about the issue, so i haven't started working on it.
Can you please elaborate such that it will be easy for me to work on

@HeetVekariya
Copy link

  • @LakshanWeerasinghe @keizer619 what i understand the issue as, we don't have to allow the user to have directory names "dist" and "update"

  • Current _bal.sh

new)
        _arguments \
            '1: :(-t --template)' \
            '*:: :->templates'
        ;;
  • Changes which will not allow directory names dist & update
new)
    _arguments \
        '1: :(-t --template)' \
        '2: :_files -W * -/' \
        - '2: :(dist update)'
    ;;
  • Is it correct ?

@LakshanWeerasinghe
Copy link
Author

In here when we try to execute one of these commands it will prints an error saying Unmatched argument at index 0: 'new'. There are two things we can do this for this issue.

  1. Make the bal new command to work properly for these types for project names.
  2. Give a proper error message to the user so that the user won't get confused.

@azinneera @Dilhasha what approach we should follow?

@HeetVekariya
Copy link

  • @LakshanWeerasinghe let me know the option, whenever finalised, with which we are going to proceed.
  • I will work accordingly.

@udda1996
Copy link
Contributor

udda1996 commented Oct 27, 2023

@HeetVekariya we should allow users to create projects with names with keywords like update , dist. Currently this is fixed for update keyword and bal new update is working fine. you can refer to below PR to have an idea on this fix #312 .

Hope you can start work on this issue with the given instructions. Feel free to raise any issue you come across while working on this.

@HeetVekariya
Copy link

i might not able to work on this issue, so can you please assign this issue to others

Copy link

This issue is NOT closed with a proper Reason/ label. Make sure to add proper reason label before closing. Please add or leave a comment with the proper reason label now.

      - Reason/EngineeringMistake - The issue occurred due to a mistake made in the past.
      - Reason/Regression - The issue has introduced a regression.
      - Reason/MultipleComponentInteraction - Issue occured due to interactions in multiple components.
      - Reason/Complex - Issue occurred due to complex scenario.
      - Reason/Invalid - Issue is invalid.
      - Reason/Other - None of the above cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants